Repository navigation
Enforce solution RID validation for no-incremental builds - #56379
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unexpected behavior of dotnet build with --no-incremental
Enforce solution RID validation for no-incremental builds
Sep 22, 2026
marcpopMSFT
marked this pull request as ready for review
September 29, 2026 20:50
marcpopMSFT
requested review from
baronfel
and
a balanced review from Copilot
September 29, 2026 20:50
baronfel
approved these changes
Sep 29, 2026
baronfel
enabled auto-merge
September 29, 2026 20:54
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Rebuild regression row also runs Build, so it can pass without validating the production fix.
Review effort: Balanced
Findings: 1
What changed in this PR
Enforces solution-level RID validation for both normal and non-incremental solution builds.
Changes:
- Runs RID validation before
Rebuild. - Parameterizes regression coverage for
BuildandRebuild.
| File | Description |
|---|---|
Microsoft.NET.Sdk.Solution.targets |
Adds Rebuild validation. |
GivenThatWeWantToBuildWithARuntimeIdentifier.cs |
Adds target-specific regression cases. |
| var buildCommand = new BuildCommand(Log, testAsset.TestRoot, "App.sln"); | ||
| buildCommand | ||
| .Execute($"/p:RuntimeIdentifier={ToolsetInfo.LatestWinRuntimeIdentifier}-x64") | ||
| .Execute($"/t:{target}", $"/p:RuntimeIdentifier={ToolsetInfo.LatestWinRuntimeIdentifier}-x64") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet build --runtime <RID> solution.slncorrectly rejects solution-level RIDs, but adding--no-incrementalselectedRebuildand bypassed NETSDK1134.Validation
_CheckForSolutionLevelRuntimeIdentifierbefore bothBuildandRebuild.Regression coverage