Repository navigation
[release/11.0.1xx] Defer package help to the managed CLI in AOT mode - #56421
Merged
Merged
Conversation
Manual backport of #56417. In AOT mode, help for the package subtree is now rendered by the managed CLI, which adds NuGet-contributed subcommands such as 'package update'. Help for the nuget tree is already forwarded to the NuGet CLI in both modes. Conflict resolution: this branch lacks the AOT 'test --test-modules' tests adjacent to the insertion point; only the two new tests were kept. (cherry picked from commit 61ecee1) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/tactics |
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Add integration coverage confirming package --help and package update --help use the managed CLI.
Review effort: Lite
Findings: None
What changed in this PR
Backports AOT help handling so dotnet package help is delegated to the managed CLI.
Changes:
- Defers
packagesubtree help in AOT mode. - Adds parser regression tests for package and NuGet help handling.
- Tests do not yet verify user-visible managed fallback output.
| File | Summary |
|---|---|
test/dotnet-aot.Tests/AotParserTests.cs |
Adds parser-level coverage; needs an integration test for actual help output. |
src/Cli/dotnet/Parser.cs |
Registers package for managed CLI help fallback. |
marcpopMSFT
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #56417 to release/11.0.1xx. The automatic backport failed because of merge conflicts.
Summary
The dotnet CLI's AOT mode hid help output for package-management-related commands due to a gap in the fallback logic that delegated to the managed CLI implementation.
Customer Impact
Customers that were looking for information about package-related commands could not see it until/unless they knew to run the non-AOT CLI via setting an environment variable. The commands themselves would work, just help output was missing.
Regression?
Yes, since 11 preview 7.
Testing
New tests have been added to the AOT parser to ensure that the managed fallback is used when these commands are requested at all.
Risk
Low - we already use this mechanism for other commands that need managed fallback at this point in time.