Repository navigation
[release/11.0.1xx] Port signature verification changes from PR 56468 - #56472
Merged
joeloff merged 4 commits intoOct 16, 2026
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: joeloff <7409981+joeloff@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The security-sensitive extraction path lacks focused regression coverage proving verification occurs before MSI execution.
1 open finding
What changed in this PR
Adds Authenticode verification before administrative extraction of workload manifest MSIs.
Changes:
- Exposes the existing MSI signature verifier internally.
- Injects and invokes signature verification during manifest extraction.
- Wires the full MSI installer to the cache verifier.
| File | Description |
|---|---|
MsiPackageCache.cs |
Makes the signature verifier internally accessible. |
WindowsMsiManifestInstaller.cs |
Verifies MSI payloads before extraction. |
NetSdkMsiInstallerClient.cs |
Supplies the existing cache verifier. |
🧠 Review effort: Balanced
| string resolvedMsiPath = msiPath!; | ||
| string msiExtractionPath = Path.Combine(extractionPath, "msi"); | ||
|
|
||
| verifyPackageSignature?.Invoke(resolvedMsiPath); |
Contributor
Author
There was a problem hiding this comment.
Added the focused verifier regression test in commit 6411120. It asserts the callback receives the resolved MSI path and throws a sentinel before native installation.
joeloff
changed the title
joeloff
changed the title
Co-authored-by: joeloff <7409981+joeloff@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
marcpopMSFT
approved these changes
Oct 16, 2026
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release/11.0.1xxbranch context and identify where MSI manifest extraction runs after the branch refactor.