Repository navigation
Shorten Windows desktop test project path - #56503
Merged
Merged
Conversation
Use a concise explicit project name so the generated editorconfig path stays below MAX_PATH on Full Framework test legs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
Review effort: Lite
Findings: None
What changed in this PR
Updates a Windows Desktop build test to use an explicitly named TestProject, likely to improve identification/isolation of the test project created for the scenario.
Changes:
- Set an explicit project name (
"SupportedOSPlatform") when constructingTestProjectinSupportedOSPlatformVersionCanBeSetInDirectoryBuildTargets.
| File | Description |
|---|---|
| test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildAWindowsDesktopProject.cs | Names the TestProject instance explicitly in the SupportedOSPlatform version test. |
dsplaisted
approved these changes
Oct 6, 2026
Co-authored-by: Daniel Plaisted <daplaist@microsoft.com>
Evangelink
approved these changes
Oct 9, 2026
Member
|
I'm hitting this is in 10 branches too, I assume we're back porting this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is part of the weekly test issue cleanup effort.
Give
SupportedOSPlatformVersionCanBeSetInDirectoryBuildTargetsa concise explicit project name instead of inheriting its long test method name. The project name is repeated in the generated project directory, project filename, andGeneratedMSBuildEditorConfigfilename, which pushed the Full Framework Windows Helix path overMAX_PATH.Under the same intentionally elongated local test root, this reduces the generated editorconfig path from 433 to 355 characters. Under the normal test root, the resulting path is approximately 246 characters.
Fixes #56499
Validation:
scripts\RunTests.cswith the exact test filter and desktop MSBuildDOTNET_SDK_TEST_EXECUTION_DIRECTORY