Repository navigation
Remove VersionOverride from Releases package reference - #56506
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: joeloff <7409981+joeloff@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove VersionOverride metadata for Microsoft.Deployment.DotNet.Releases
Remove VersionOverride from Releases package reference
Oct 5, 2026
joeloff
marked this pull request as ready for review
October 5, 2026 22:27
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Compatibility of the newly selected dependency with minimum-supported Visual Studio/MSBuild hosts remains unverified.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns the MSBuild SDK resolver’s Releases dependency with standard package version resolution, intending to pick up newer fixes.
Changes:
- Removes the toolset-specific
VersionOverridewhile retaining the package reference.
| File | Description |
|---|---|
| src/Resolvers/Microsoft.DotNet.MSBuildSdkResolver/Microsoft.DotNet.MSBuildSdkResolver.csproj | Uses standard version resolution for Microsoft.Deployment.DotNet.Releases. |
Member
|
Built a local copy of the PR to verify the DLL. Below is from the MSBuildExtensions package that's inserted into VS 
|
nagilson
approved these changes
Oct 6, 2026
Member
|
/backport to release/11.0.2xx |
Contributor
|
Started backporting to |
Member
|
/backport to main |
Contributor
|
Started backporting to |
This was referenced Oct 6, 2026
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MSBuild SDK resolver explicitly overrode the version of
Microsoft.Deployment.DotNet.Releases. Remove that override while retaining the package reference.Additional Context
VS consumes the copy of the DLL through PrivateAssemblies. The version in VS is very old and missing performance fixes that were made in dotnet/deployment-tools#545.
There is also a secondary risk of missing other fixes in the future.
Risk
Low
Testing
Manually verification to ensure the version is consistent.
Workaround
VS has to manually override the copy in private assemblies. This still leaves an older copy inside the msbuild resolver.