Repository navigation
Validate browser launch URL - #56663
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new scheme restriction needs regression coverage for absolute non-HTTP URLs.
1 open finding
What changed in this PR
Validates URLs extracted from application output before dotnet watch launches a browser.
Changes:
- Restricts observed URLs to absolute HTTP/HTTPS URLs and excludes trailing whitespace.
- Moves Aspire-host detection into
BrowserLauncher. - Adds URL-matching tests for standard and Aspire output.
| File | Description |
|---|---|
| test/dotnet-watch.Tests/Browser/WebServerProcessStateObserverTests.cs | Adds URL acceptance and rejection tests. |
| src/Dotnet.Watch/Watch/Process/WebServerProcessStateObserver.cs | Tightens URL extraction and validates schemes. |
| src/Dotnet.Watch/Watch/Browser/BrowserLauncher.cs | Passes Aspire-host status to the observer. |
🧠 Review effort: Balanced
DustinCampbell
approved these changes
Oct 15, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tmat
enabled auto-merge (squash)
October 15, 2026 22:45
DustinCampbell
approved these changes
Oct 16, 2026
tmat
had a problem deploying
to
copilot-pat-pool
October 16, 2026 17:12 — with 
GitHub Actions
Failure
GitHub Actions
Failure
This was referenced Oct 26, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.