Repository navigation
Better handle named pipe disconnection - #56683
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
genlu
approved these changes
Oct 16, 2026
tmat
enabled auto-merge (squash)
October 16, 2026 22:27
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new disconnection-before-cancellation behavior needs deterministic regression coverage.
1 open issue
What changed in this PR
Improves dotnet watch Hot Reload handling when a connection terminates before cancellation is signaled.
Changes:
- Treat expected transport termination during updates as cancellation.
- Consolidate exception details into one failure log entry and remove the separate stack-trace reporter descriptor.
| File | Description |
|---|---|
| src/Dotnet.Watch/Watch/UI/IReporter.cs | Removes the separate stack-trace descriptor. |
| src/Dotnet.Watch/HotReloadClient/HotReloadClient.cs | Logs full exception details in one entry. |
| src/Dotnet.Watch/HotReloadClient/DefaultHotReloadClient.cs | Converts expected connection termination into cancellation. |
Review effort: Balanced
genlu
approved these changes
Oct 16, 2026
tmat
had a problem deploying
to
copilot-pat-pool
October 17, 2026 00:04 — with 
GitHub Actions
Failure
GitHub Actions
Failure
This was referenced Oct 26, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.