Repository navigation
Re-enable legacy contracts restore test - #56788
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6012cd00-09a4-4070-921b-a256bd44dca4
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change only removes a test skip, restoring existing coverage without changing production behavior or test logic.
No open issues 🎉
What changed in this PR
Re-enables the existing legacy-contract regression test in the SDK build test suite, restoring coverage associated with issue #3044.
Changes:
- Removes the
Ignoreattribute fromReferenceLegacyContracts. - Leaves test logic, assertions, and production code unchanged.
| File | Description |
|---|---|
test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildANetCoreApp.cs |
Re-enables the legacy-contract restore and build test. |
Review effort: Balanced
JoeRobich
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Part of the weekly SDK test issue cleanup effort.
Re-enables
GivenThatWeWantToBuildANetCoreApp.ReferenceLegacyContracts, which verifies that projects can restore and build when referencing legacy contract packages from different .NET 1.x bands while using a runtime identifier.The original restore failure is no longer reproducible with the current SDK. The test passed three consecutive local runs against a freshly built Debug redist.
Closes #3044.