Skip to content

Update roslyn to 5.13.0-1.26507.4 - #9851

Merged
dibarbet merged 5 commits into
dotnet:mainfrom
dibarbet:dibarbet-update-roslyn-latest
Oct 7, 2026
Merged

dibarbet merged 5 commits into
dotnet:mainfrom
dibarbet:dibarbet-update-roslyn-latest

Conversation

@dibarbet

@dibarbet dibarbet commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Roslyn build: 20261007.4 (5.13.0-1.26507.4)

Publish Assets succeeded; the overall build failed in the separate OneLocBuild localization step.

View Complete Diff of Changes

  • Unsafe evolution: require annotation for layout with pack or size (PR: #85921)
  • Handle missing symlink privileges when running a test locally (PR: #85919)
  • Verify semantic symbols in using expression tests (PR: #85847)
  • Unsafe evolutions: require AllowUnsafeBlocks for the safe keyword (PR: #85784)
  • Remove unused Razor content type constants (PR: #85928)
  • Fix close tag completion replacement ranges (PR: #85710)
  • Reuse ToList lowering for single spreads into mutable list interfaces (PR: #85777)
  • Publish Microsoft.NET.ProjectData.Tasks to vs-impl (PR: #85938)
  • Fix LanguageServer Telemetry Reading (PR: #85936)
  • Add type suffix options to TypedConstant formatting (PR: #85830)
  • Prevent odd document Uris from causing inadvertent syntax errors (PR: #85886)
  • Add code actions for documentation diagnostics (PR: #85728)
  • Add logging for a hung BuildHost during shutdown (PR: #85908)
  • Fix the language-server publish race (PR: #85925)
  • Unify Razor diagnostics to a single endpoint (PR: #85867)
  • Handle Razor text views without adapters (PR: #85863)
  • Add folding ranges for documentation directives (PR: #85725)
  • Add semantic-token support for documentation directives (PR: #85724)
  • Add documentation formatting, completion and snippets (PR: #85727)
  • Ensure we dispose ITextEdits in case we fail to apply them (PR: #85884)
  • Mirror ProjectData 265321fe: reader, generator, and build-task projects (PR: #85851)
  • Add the documentation directive to the Razor compiler (PR: #85723)
  • Cleanup LanguageServerProjectLoadingTests (PR: #85906)
  • Reduce IL size for constructing ImmutableArray<T> of small sizes (PR: #85797)
  • Make server initialization log assertions thread-safe (PR: #85899)
  • Document known issue workarounds inline (PR: #85896)
  • Restore automatic HTML test results for local runs (PR: #85892)
  • Convert generic brackets to braces when pasting into cref (PR: #85787)
  • Report actual errors when strong-name HRESULT assertions fail (PR: #85894)
  • Restore main insertions after the VS 18.12 snap (PR: #85824)
  • Move extension handler API to Workspaces (PR: #85209)
  • Add "edit criteria" for AI doc updates (PR: #85893)
  • Improve our Copilot instructions for testing (PR: #85882)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 7, 2026 17:07
@dibarbet
dibarbet requested a review from a team as a code owner October 7, 2026 17:07
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The changelog includes one infrastructure-only and one Visual Studio-only change.

1 open finding
What changed in this PR

Updates the shared Roslyn language-server and Dev Kit dependency to 5.13.0-1.26506.2.

Changes:

  • Bumps the shared Roslyn package version.
  • Adds selected release notes to the changelog.
File Description
package.json Updates the Roslyn version.
CHANGELOG.md Documents selected Roslyn changes.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CHANGELOG.md Resolved
Updated Roslyn to version 5.13.0-1.26506.2 with several enhancements and fixes.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 7, 2026 17:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The changelog incorrectly includes a Visual Studio-only feature.

0 open findings

1 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Low severity Remove Visual Studio-only Roslyn change from user-facing changelog

CHANGELOG.md:13

Remove this entry because the linked Roslyn change is Visual Studio-only: it adds an ICommandHandler<PasteCommandArgs> under src/EditorFeatures using Microsoft.VisualStudio.Commanding and text-buffer APIs, so the feature is not exposed by the VS Code language server. The Roslyn update guidance explicitly excludes Visual Studio-only changes from this user-facing changelog (.github/skills/update-roslyn-version/SKILL.md:178-200).

🧠 Review effort: Balanced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 7, 2026 18:50
@dibarbet dibarbet changed the title Update roslyn to 5.13.0-1.26506.2 Update roslyn to 5.13.0-1.26507.4 Oct 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The changelog includes a Visual Studio-only feature unavailable in VS Code.

1 open finding

🧠 Review effort: Balanced

Comment thread CHANGELOG.md Resolved
Added new features for documentation directives and updated Roslyn version.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 7, 2026 18:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused version and changelog updates are consistent and complete.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@dibarbet
dibarbet merged commit bc52850 into dotnet:main Oct 7, 2026
32 checks passed
@dibarbet
dibarbet deleted the dibarbet-update-roslyn-latest branch October 7, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants