Fix for intermittent test failure on x86 platform 'BindingContext_UpdateBinding_UpdateListBindingWithoutDataMember_Success' - #14359
Merged
Conversation
Issue: context1 was getting garbage collected after UpdateBinding call to context2 causing the assertions to fail. Fix: Obtain a strong reference to manager1 before calling UpdateBinding.
Shyam-Gupta
added
test-bug
Shyam-Gupta
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14359 +/- ##
===================================================
+ Coverage 77.31249% 77.31528% +0.00279%
===================================================
Files 3265 3265
Lines 644447 644447
Branches 47631 47631
===================================================
+ Hits 498238 498256 +18
+ Misses 142520 142501 -19
- Partials 3689 3690 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
merriemcgaw
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Intermittent
BindingContext_UpdateBinding_UpdateListBindingWithoutDataMember_Successtest failure on x86 platformCI test failure against 11.0-preview2: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1321935&view=ms.vss-test-web.build-test-results-tab&runId=36910776&resultId=116411&paneView=debug
Root cause:
context1was getting garbage collected afterUpdateBindingcall tocontext2causing the assertions to fail.Fix: Obtain a strong reference to
manager1before callingUpdateBinding.Microsoft Reviewers: Open in CodeFlow