[apple] [infra] Refactor unification of app and main logs for iOS devices and MacCatalyst

[matouskozak]

Refactor unification of app and main logs for iOS devices and MacCatalyst :

• Move the logic of unifying the app and main logs to the TestOrchestrator.
• Copy system and application logs to the main log after the app has finished.

Example of refactored reporting: https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-xharness-refs-pull-1383-merge-253e93d337aa4abdbb/tvos-device-System.Buffers.Tests.app/1/console.f4e82d5e.log?helixlogtype=result

---

Possibly fixing #1382

[ivanpovazan]

I think this is OK and thanks for the fix.

One thing to consider is putting the log merging behind a CLI parameter which is not enabled by default, but rather from our testing infra.
Yes, that is more work, but what I found "annoying" is that now when you run a test/app from command line on Android the terminal gets polluted with the whole adb logcat output. From UX perspective we don't want that and should at least provide a way to turn it off.

/cc: @akoeplinger for thoughts

[matouskozak]

One thing to consider is putting the log merging behind a CLI parameter which is not enabled by default, but rather from our testing infra. Yes, that is more work, but what I found "annoying" is that now when you run a test/app from command line on Android the terminal gets polluted with the whole adb logcat output. From UX perspective we don't want that and should at least provide a way to turn it off.

That's a very good point, one that I haven't considered much before. I think we could add it as apple test / android test argument. I'll open a follow-up issue (#1386) to address this as I would like to get this change in asap to verify that it fixes the runtime test logging issue.

[matouskozak]

fyi: moved the log merging after the ParseResult call to not affect the logs before they get parsed.

[akoeplinger]

LGTM. I agree we should add the CLI option for opting-in

[matouskozak]

/ba-g failure is a known issue