Repository navigation
feat: rename sortTypeOnlyImports/sortTypeOnlyExports value none to inline - #885
Merged
Merged
Conversation
…inline` in `dprint config update`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #671
Renames the
nonevalue ofimportDeclaration.sortTypeOnlyImportsandexportDeclaration.sortTypeOnlyExportstoinline, which describes what it does: type-only named imports and exports are sorted inline with the others.nonekeeps working:dprint config updaterewrites"none"to"inline"in the config file.nonetoinline, without a diagnostic (a diagnostic would stop formatting).inlineand keepsnone, described as deprecated, so existing configs still validate.The resolved configuration serializes the value as
"inline"and still deserializes"none".For Rust users,
NamedTypeImportsExportsOrder::Noneis renamed toNamedTypeImportsExportsOrder::Inline.Tests
resolve_config.rscover resolving each value (includingnone), the serde round trip, and which valuesdprint config updaterewrites.NamedImports_SortNamedTypeImports_Inline.txtandNamedExports_SortNamedTypeExports_Inline.txtuseinline, and the existing_None.txtspecs still usenone.