Repository navigation
fix: keep a comment on the lines before an argument on its own lines - #924
Merged
Merged
Conversation
dsherret
force-pushed
the
fix-block-comment-before-argument
branch
from
November 13, 2026 22:41
28e137f to
f7daa3d
Compare
dsherret
force-pushed
the
fix-block-comment-before-argument
branch
from
November 13, 2026 22:45
f7daa3d to
4e46a70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #919
Stacked on #923.
A comment on its own lines before a value that's allowed to span multiple lines beside the other values (a function, arrow function, object, array, etc.) didn't cause the list to break, so the comment ended up at the end of the previous value's line:
A value with a comment like that is now treated as being multi-line and not allowed to be inline, so the values go on separate lines (or stay hanging with
preferHanging) and the comment stays above its value. A block comment that's beside its value (ex.call(a, /* comment */ () => {})) doesn't change anything.