Repository navigation
fix: only keep the parens of a for of or for in statement beside a multi-line last value when the header doesn't fit on a line - #930
Merged
Conversation
…lti-line last value when the header doesn't fit on a line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #923.
Since #923 the parens of a
for...oforfor...instatement stay beside a multi-line right side. That also applied when the right side only became multi-line because of it, so a header that used to fit on its own line got its array or arguments broken up instead:Now the header is tried on its own lines first and stays that way when it fits on a single line there, which is what 0.100.0 did. The parens only stay beside the right side when it's multi-line either way:
Only one of the two layouts is printed at a time, so the condition remembers what it found out about each one at the position it's at.
Formatting the regressions repo with this, the hunks that got longer compared to 0.100.0 are gone, and what's left are the headers that now take two fewer lines.