Skip to content

fix(canvas): read deltaX so shift + wheel scrolls horizontally in Chrome #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ntdatt812 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(canvas): read deltaX so shift + wheel scrolls horizontally in Chrome #1133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/EditorCanvas/Canvas.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,12 +699,18 @@ export default function Canvas() {
},
zoom: e.deltaY <= 0 ? prev.zoom * 1.05 : prev.zoom / 1.05,
}));
} else if (e.shiftKey) {
} else if (e.shiftKey || e.deltaX !== 0) {
// Browsers disagree about where a horizontal scroll arrives. Chrome
// translates shift + wheel into deltaX and leaves deltaY at 0, so
// reading deltaY alone added nothing and the diagram did not move.
// Firefox keeps it on deltaY with shiftKey set. A trackpad or a tilt
// wheel sends deltaX with no modifier at all.
const horizontal = e.deltaX !== 0 ? e.deltaX : e.deltaY;
setTransform((prev) => ({
...prev,
pan: {
...prev.pan,
x: prev.pan.x + e.deltaY / prev.zoom,
x: prev.pan.x + horizontal / prev.zoom,
},
}));
} else {
Expand Down
Loading