Initial product variation logging PoC#801
Open
heddn wants to merge 4 commits into
Open
Conversation
Author
|
It looks like the following. I'd like feedback on the text of the wording and placement of where to put the UI components of the log. Right now I have it placed on the product edit page.
|
Author
|
For the field diffs, I'm using a json serialized string of the original value compared to the current value. Where value is retrieved from the field using |
added 2 commits
October 5, 2017 11:03
…product_variations Conflicts: modules/log/commerce_log.module modules/log/src/CommerceLogServiceProvider.php modules/log/src/Event/ProductVariationChangedFieldsFilterEvent.php
heddn
commented
Oct 5, 2017
heddn
left a comment
heddn
left a comment
Author
There was a problem hiding this comment.
The tests were failing because we now have more events and the hard coded ids in the tests were off. I'm using array_pop now instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.