Skip to content

Fix: Comparison can be timezone aware #10

Merged
cunla merged 2 commits into
dsoftwareinc:masterfrom
eco-JoshuaJackson:master
Nov 10, 2025
Merged

Fix: Comparison can be timezone aware #10
cunla merged 2 commits into
dsoftwareinc:masterfrom
eco-JoshuaJackson:master

Conversation

@eco-JoshuaJackson

Copy link
Copy Markdown
Contributor

Why do we need this change?

Depending on the setup and return from github, the date/time can be timezone aware. This leads to an error TypeError: can't compare offset-naive and offset-aware datetimes that prevents updating repo's appropriately.

What effects does this change have?

@eco-JoshuaJackson

Copy link
Copy Markdown
Contributor Author

@cunla Just want to make sure that you saw the bug and this pr and please let me know if you have any questions about it, or if there's any adjustments needed.

@cunla

cunla commented Nov 1, 2025

Copy link
Copy Markdown
Contributor

@cunla Just want to make sure that you saw the bug and this pr and please let me know if you have any questions about it, or if there's any adjustments needed.

I will look into it later this month

@cunla

cunla commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

Hi, do you mind removing the linter changes? I think we use different settings and it causes a lot of "noise" here.

@eco-JoshuaJackson

eco-JoshuaJackson commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

Hi, do you mind removing the linter changes? I think we use different settings and it causes a lot of "noise" here.

In which case I would suggest publishing the linter configurations that you leverage as part of the repo be it the settings for black, ruff etc so that it remains consistent to the standards you want.

But I've updated to be the bare minimal of changes now so it should be easier to review.

Also of note oddly enough for a design that's meant to update steps to the latest, the steps in this repo could use an update as well.

@cunla
cunla merged commit 496b48c into dsoftwareinc:master Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timezone aware datetime not being handled approriately

2 participants