Problem
Both CI workflows (ci.yml:53-56, ci_full.yml:44-47) and the Makefile silently --ignore three test files:
test_database_types.py (818 lines) — the most comprehensive type-coverage test exercising every driver's type handling. For a cross-database diff tool, this is arguably the most important test file.
test_main.py (249 lines) — tests the CLI entry point
test_dbt_config_validators.py (33 lines) — likely uses Pydantic v1 parse_obj API
No comment explains why these are excluded. CI shows green while skipping critical coverage.
Scope
- Run each excluded test file locally to identify failures
- Fix the failures (likely Pydantic v1→v2 migration for validators, possible import issues for others)
- Re-enable in CI, or add explicit
pytest.mark.skip with documented reason
- Remove
--ignore flags from ci.yml, ci_full.yml, and Makefile
Key Files
.github/workflows/ci.yml:53-56
.github/workflows/ci_full.yml:44-47
Makefile
tests/test_database_types.py
tests/test_main.py
tests/test_dbt_config_validators.py
Acceptance Criteria
Problem
Both CI workflows (
ci.yml:53-56,ci_full.yml:44-47) and the Makefile silently--ignorethree test files:test_database_types.py(818 lines) — the most comprehensive type-coverage test exercising every driver's type handling. For a cross-database diff tool, this is arguably the most important test file.test_main.py(249 lines) — tests the CLI entry pointtest_dbt_config_validators.py(33 lines) — likely uses Pydantic v1parse_objAPINo comment explains why these are excluded. CI shows green while skipping critical coverage.
Scope
pytest.mark.skipwith documented reason--ignoreflags fromci.yml,ci_full.yml, andMakefileKey Files
.github/workflows/ci.yml:53-56.github/workflows/ci_full.yml:44-47Makefiletests/test_database_types.pytests/test_main.pytests/test_dbt_config_validators.pyAcceptance Criteria
--ignoreflags removed from CI workflows and Makefile