migrate http-assert to another deep equality library #16

Activity

1. 43081j

   added

   help wantedExtra attention is neededExtra attention is needed

   on Jan 27, 2024
2. mehulkar commented on Jan 29, 2024

   

   mehulkar

   on Jan 29, 2024

   More actions

   Test suite passes, but no idea if that's enough for this jshttp/http-assert#15
3. 43081j commented on Jan 29, 2024

   

   43081j

   on Jan 29, 2024

   Last edited by 43081j

   CollaboratorAuthor

   More actions

   awesome work @mehulkar , if you need any help along the way do feel free to pull me into an issue/pr

   looks like they want to maintain deep loose equality.

   it would basically mean something like equal({a: null}, {a: undefined}) would be true if we did it non-strict.

   deep-eql does let you pass a custom comparator, something like:

   deepEqual(left, right, {
     comparator: (a, b) => {
       if(typeof a === 'object' || typeof b === 'object') {
         return null; // this tells deep-eql to carry on using default behaviour
       }
       return a == b;
     }
   });

   maybe we could do this inside http-assert.

   some day i could talk to the other chai maintainers about having a loose equality comparator built in too maybe.
4. Fuzzyma

   added

   has issueAn issue for contact or tracking was created in the target repositoryAn issue for contact or tracking was created in the target repository

   blockedThis issue should be checked regurlarly if the condition to unblock it is metThis issue should be checked regurlarly if the condition to unblock it is met

   and removed

   help wantedExtra attention is neededExtra attention is needed

   on Dec 18, 2024