Add extension_name parameter - #5259
Open
Flamefire wants to merge 3 commits into
Open
Conversation
When set for an extension it is used instead of its name in the extension list of the module. When set for a (root) easyconfig it will add an extension entry for it.
This currently only happens when the module is created, but not when the actual extension is created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When set for an extension it is used instead of its name in the extension list of the module.
When set for a (root) easyconfig it will add an extension entry for it.
This can then be used by easyblocks e.g. to check for Python package name in
pip list.I would also combine it with #5257 : When
extension_nameis set it is used as the default forload_name. I expect that this applies to many packages. E.g.PyTorchis listed and loaded astorchI also found and fixed a bug/inconsistency: For string-extensions templates were only resolved in
make_extension_listbut not incollect_exts_file_infoAs for templating:
extension_nametemplates are resolved using the extension templates, i.e.%(name)sis that of the extension, not the parent EC. That is consistent with the other options.Initial draft done by AI, manually verified and adjusted afterwards