Repository navigation
General Wrynose, KAS, GitHub Workflows, Pre-Commit maintenance on repo - #220
Merged
Merged
Conversation
Validate the kas and GitHub workflow YAML and the Markdown documentation before they are committed. The rule set is relaxed for prose style rules that clash with the Eclipse boilerplate, see docs/pre-commit.md.
The scarthgap dry-run fails: packagegroup-sdv-core pulls crun -> wasmedge, which DEPENDS on lld, and no lld recipe exists in oe-core or meta-clang for scarthgap. meta-virtualization for scarthgap has no containerd recipe either, so the meta-leda bbappends for lld and containerd are left dangling. Remove the scarthgap kas config and list only wrynose in LAYERSERIES_COMPAT, document the resulting release and machine matrix in docs/ci-build-matrix.md.
Keep the working curated rulefile, the layer constants file and the recorded findings in docs/oelint-adv-eval so the evaluation can be repeated. The linter itself stays out of pre-commit and CI for now.
Installing pre-commit with sudo pip3 into the interpreter of the runner fails on the ubuntu runners: pip there is patched to uninstall the packages the distribution ships first, and pre-commit depends on packaging, which is shipped as python3-packaging. That uninstall has no RECORD file to undo, so pip exits with an error and the job aborts. The upstream action installs into the interpreter of actions/setup-python instead, and caches ~/.cache/pre-commit.
A push to a branch that has an open pull request fires both the push and the pull_request event, so the unscoped push trigger started a second identical run of the job. The pull_request trigger already covers every push to a pull request, including the ones from forks, and workflow_dispatch covers the cases where a maintainer wants a run for a branch. A direct push to a release branch (main, wrynose, scarthgap, ...) is not checked in CI any more: the maintainer runs the same commands locally before pushing, and the change is checked by the next pull request that touches it. The docs of both workflows are updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrynosebranch.. For scarthgap, usescarthgapbranch.