Skip to content

score's llvm_cov integration filters @flatbuffers//:include/flatbuffers/*.h in the report out #558

Closed

Description

@paulquiring

What

score_tooling's coverage_scope aspect (coverage_scope.bzl,
_coverage_scope_aspect_impl) walks hdrs/srcs of workspace targets but
unconditionally drops any File whose path starts with external/. Since
flatbufferscpp's hdrs point at @flatbuffers//:include/flatbuffers/*.h,
those files were filtered out of the coverage allowlist even though the
owning target (//score/flatbuffers:flatbufferscpp) is listed in
tools/coverage/BUILD's coverage_scope.deps.

This needs to be discussed.

Acceptance Criteria (DoD)

decision is taken

How

No response

Activity

  1. added theissue type on Sep 4, 2026
  2. self-assigned this
    on Sep 4, 2026
  3. paulquiring commented on Sep 10, 2026

    @paulquiring
    ContributorAuthor

    This change 9e663f0#diff-584c1daa0236fb15e449fca7530da0ef790eb54e5f26723b01e474165f8d32c1L48
    caused the header files flatbuffers/*.h to vanish form the coverage report. PR #577 provides patch candidates for score_tooling to fix that. @dcalavrezo-qorix would it be possible to adapt those?

  4. moved this from In Progress to Done in BAS - Baselibs FTon Sep 14, 2026
  5. added a commit that references this issue on Sep 14, 2026
    fc3c988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

comp-flatbuffersRelated to score/flatbuffers component

Type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions