Skip to content

json: verify and address compatibility for cross-repo persistence consumers after refactoring #680

Open

Description

@Nikhil2206

Parent: #642

What

The epic's "Maintain compatibility and migrate users" scope only assesses dependents inside the baselibs repo (it names score/hash and logging config as examples). score/json is also consumed as the external score_baselibs Bazel module by at least two sibling S-CORE repos that persist data through a full JSON write-then-read round trip, not just one-way parsing:

  • persistency/score/kvs/kvs.cpp — the key-value-store component owns both score::json::JsonWriter and score::json::JsonParser directly. It calls writer->ToBuffer(root_obj) to persist state and parses it back later. This is exactly the "reading data from a persistence partition" scenario the epic calls out as an Assumption-of-Use boundary.
  • config_management/.../config_daemon/code/json_helper/ — JsonHelper/JsonHelperImpl wraps both json::IJsonWriter and the parser behind its own interface, used by the config-daemon's parameter-set persistence (parameter_set_impl.cpp, parameterset_collection_impl.cpp).

Both are directly exposed to:

Neither consumer is tracked by any of the epic's other sub-issues today, and because they live in different repos, they won't be caught by bazel test //score/... in baselibs CI.

Acceptance Criteria (DoD)

How

No response.

Activity

  1. changed the title [-]json: assess cross-repo persistence consumers (persistency/kvs, config_management/json_helper) for the consolidated writer/parser[/-] [+]json: verify and address compatibility for cross-repo persistence consumers (persistency/kvs, config_management/json_helper) for the consolidated writer/parser[/+] on Oct 14, 2026
  2. changed the title [-]json: verify and address compatibility for cross-repo persistence consumers (persistency/kvs, config_management/json_helper) for the consolidated writer/parser[/-] [+]json: verify and address compatibility for cross-repo persistence consumers after refactoring[/+] on Oct 14, 2026
  3. added theissue type on Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    comp-jsonRelated to score/json component

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions