Repository navigation
workflows: keep going and collect clang-tidy reports on CI - #538
Merged
Merged
Conversation
github-actions
Bot
added
c++
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
Documentation preview for this pull request is available at: |
4 tasks done
fbaeuerle
force-pushed
the
fb/clang_tidy_reports
branch
2 times, most recently
from
September 3, 2026 11:44
fa2e7ea to
7c04793
Compare
github-actions
Bot
removed
c++
fbaeuerle
marked this pull request as ready for review
September 3, 2026 14:35
fbaeuerle
requested review from
4og,
antonkri,
arkjedrz and
pawelrutkaq
as code owners
September 3, 2026 14:35
4og
requested changes
Sep 3, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The clang-tidy configuration unintentionally disables checks and contains a malformed check list.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Extends clang-tidy CI to continue after failures and publish diagnostics as artifacts and code-scanning results.
Changes:
- Collects raw clang-tidy reports and normalized SARIF.
- Adds privileged SARIF upload handling for fork PRs.
- Alters the enabled clang-tidy checks.
File summaries
| File | Description |
|---|---|
.github/workflows/lint.yml |
Collects and uploads clang-tidy reports. |
.github/workflows/lint_sarif_upload.yml |
Uploads fork-PR SARIF results. |
.github/tools/clean_clang_tidy_sarif.py |
Normalizes SARIF rules and paths. |
.clang-tidy |
Changes enabled and error-level checks. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| readability-*, | ||
| -readability-avoid-const-params-in-decls, | ||
| -readability-avoid-return-with-void-value, | ||
| modernize-* |
Comment on lines
+34
to
+37
| -readability-avoid-const-params-in-decls, | ||
| -readability-avoid-return-with-void-value, | ||
| modernize-* | ||
| -modernize-use-trailing-return-type, |
fbaeuerle
force-pushed
the
fb/clang_tidy_reports
branch
3 times, most recently
from
September 3, 2026 15:53
db24ff6 to
4c6d8de
Compare
github-actions
Bot
added
comp-static_reflection_with_serialization
fbaeuerle
force-pushed
the
fb/clang_tidy_reports
branch
2 times, most recently
from
September 4, 2026 06:10
7e0aab9 to
8867303
Compare
Stop the clang-tidy CI job from aborting on the first failure and upload reports as a workflow artifact.
Merge rules_lint's per-file clang-tidy SARIF reports into one upload with sarif-multitool. A helper script synthesizes a ruleId for each result from the check name clang-tidy appends to its message, and normalizes paths to be repo-root relative, since GitHub requires both and ignores rules_lint's own uriBaseId. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fork PRs get a read-only GITHUB_TOKEN, so lint.yml could not upload clang-tidy SARIF to code scanning for pull_request events. Bundle the SARIF and PR number as an artifact instead, and add lint_sarif_upload.yml to upload it from a privileged workflow_run, which always runs with this repo's own permissions.
Reomove some warnings that cause lots of noise and contribute little to better code.
fbaeuerle
force-pushed
the
fb/clang_tidy_reports
branch
from
September 4, 2026 06:10
8867303 to
04ea763
Compare
4og
approved these changes
Sep 4, 2026
github-project-automation
Bot
moved this from In Progress
to On Hold
in BAS - Baselibs FT
4og
removed
the
comp-static_reflection_with_serialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop the clang-tidy CI job from aborting on the first failure and
upload reports as a workflow artifact.