Skip to content

Remove Linux constraint from require_typed_memory - #539

Merged
4og merged 6 commits into
eclipse-score:mainfrom
devendrapat:depa_remove_linux_constraint
Sep 15, 2026
Merged

4og merged 6 commits into
eclipse-score:mainfrom
devendrapat:depa_remove_linux_constraint

Conversation

@devendrapat

@devendrapat devendrapat commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Removed contradictory Linux constraint from require_typed_memory config_setting as it is blocking score_communication from using this config_setting, as this was blocking score_communication from using the config_setting in their code. In this PR, changes were made to use a bool_flag constraint to set require_typed_memory flag so that score_communication can depend on it without issues.

Please refer eclipse-score/communication#1022 for the error faced by score_communication while using require_typed_memory_config_setting.

Removed contradictory Linux constraint from require_typed_memory config_setting as it is blocking score_communication from using this config_setting.

Signed-off-by: devendrapat <76650287+devendrapat@users.noreply.github.com>
@github-project-automation github-project-automation Bot moved this to In Progress in BAS - Baselibs FT Sep 2, 2026
@github-actions github-actions Bot added comp-tracing Related to score/analysis bazel Bazel and Starlark build files labels Sep 2, 2026
@devendrapat
devendrapat marked this pull request as draft September 2, 2026 09:33
@4og

4og commented Sep 2, 2026

Copy link
Copy Markdown
Member

@hoppe-and-dreams please have a look

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-539: https://eclipse-score.github.io/baselibs/pr-539/

name = "require_typed_memory", #This is a stub and should always be false
constraint_values = [
"@platforms//os:qnx",
"@platforms//os:linux", # Contradicts qnx — ensures this config_setting never matches (stub)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this, all S-CORE LoLa builds on QNX would go to typed memory. I do not think this is the intended (and aligned) consequence.

If it is indeed the desired outcome, at least the comment 3 lines above must be changed to match what the code does.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hoppe-and-dreams,
Changes were made to use a bool_flag constraint to set require_typed_memory flag so that score_communication can depend on it without issues. Also the comment above was modified a bit to convey that the flag is not used anywhere in the repository, and the bool_flag is False by default.

@devendrapat
devendrapat marked this pull request as ready for review September 11, 2026 08:06
@github-project-automation github-project-automation Bot moved this from In Progress to On Hold in BAS - Baselibs FT Sep 14, 2026
@4og
4og added this pull request to the merge queue Sep 15, 2026
Merged via the queue into eclipse-score:main with commit 560526a Sep 15, 2026
39 of 42 checks passed
@github-project-automation github-project-automation Bot moved this from On Hold to Done in BAS - Baselibs FT Sep 15, 2026

This branch was previously deployed

1 inactive deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bazel Bazel and Starlark build files comp-tracing Related to score/analysis

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants