Repository navigation
Update Bitmanipulation and Result Req Inspections - #678
Merged
Merged
Conversation
aschemmel-tech
requested review from
4og,
antonkri,
arkjedrz,
fbaeuerle and
pawelrutkaq
as code owners
October 13, 2026 13:18
github-actions
Bot
added
documentation
4og
reviewed
Oct 13, 2026
| - YES | ||
| - The inspected requirements are clear and easy to understand. Some grammar mistakes were found and were fixed in PR-2677 and PR-2480: | ||
| - NO | ||
| - The following requirement is unclear what it requires "shall provide byte and half-byte types" |
Member
There was a problem hiding this comment.
The requirement is about C++ types for byte and half-byte. Any ideas how to make it more clear?
Contributor
Author
There was a problem hiding this comment.
Not knowing what the API does, I would suggest to formulate similar to other requirements. e.g. "The bit manipulation component shall provide an API to compose byte typed values out of half-bytes and decompose byte type values into half-bytes."
aschemmel-tech
force-pushed
the
aschemmel-tech-req-inspect-updates
branch
from
October 14, 2026 11:49
d2bac7b to
6eeac08
Compare
4og
approved these changes
Oct 14, 2026
github-project-automation
Bot
moved this from In Progress
to On Hold
in BAS - Baselibs FT
Contributor
|
Documentation preview for this pull request is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers: #245