Repository navigation
Fix missing braces in visit_as_struct.h - #707
Merged
pawelrutkaq merged 1 commit intoOct 20, 2026
Merged
pawelrutkaq merged 1 commit into
pawelrutkaq merged 1 commit into
Conversation
cameron-craig-etas
requested review from
4og,
antonkri,
arkjedrz,
fbaeuerle and
pawelrutkaq
as code owners
October 19, 2026 12:21
cameron-craig-etas
deployed
to
workflow-approval
October 19, 2026 12:21 — with 
GitHub Actions
Active
GitHub Actions
Active
cameron-craig-etas
deployed
to
workflow-approval
October 19, 2026 12:21 — with
GitHub Actions
Active
GitHub Actions
Active
cameron-craig-etas
deployed
to
workflow-approval
October 19, 2026 12:21 — with
GitHub Actions
Active
GitHub Actions
Active
cameron-craig-etas
deployed
to
workflow-approval
October 19, 2026 12:21 — with
GitHub Actions
Active
GitHub Actions
Active
cameron-craig-etas
deployed
to
workflow-approval
October 19, 2026 12:21 — with
GitHub Actions
Active
GitHub Actions
Active
github-actions
Bot
added
comp-static_reflection_with_serialization
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single-line initializer fix addresses the reported warning without changing conversion behavior.
No open issues 🎉
What changed in this PR
Fixes #706 by explicitly bracing the underlying std::array initializer in the reflection visitor.
Changes:
- Adds nested braces to eliminate
-Wmissing-braceswithout changing behavior.
| File | Description |
|---|---|
| score/static_reflection_with_serialization/visitor/include/visitor/visit_as_struct.h | Removes brace elision in tuple-to-array conversion. |
Review effort: Balanced
pawelrutkaq
approved these changes
Oct 19, 2026
github-project-automation
Bot
moved this from In Progress
to On Hold
in BAS - Baselibs FT
pawelrutkaq
enabled auto-merge
October 19, 2026 13:43
auto-merge was automatically disabled
October 19, 2026 14:10
Head branch was pushed to by a user without write access
cameron-craig-etas
force-pushed
the
fix/visit-as-struct-missing-braces
branch
from
October 19, 2026 14:10
d8054e5 to
862d16b
Compare
cameron-craig-etas
deployed
to
workflow-approval
October 19, 2026 14:10 — with
GitHub Actions
Active
GitHub Actions
Active
cameron-craig-etas
deployed
to
workflow-approval
October 19, 2026 14:10 — with
GitHub Actions
Active
GitHub Actions
Active
cameron-craig-etas
deployed
to
workflow-approval
October 19, 2026 14:10 — with
GitHub Actions
Active
GitHub Actions
Active
cameron-craig-etas
deployed
to
workflow-approval
October 19, 2026 14:10 — with
GitHub Actions
Active
GitHub Actions
Active
cameron-craig-etas
deployed
to
workflow-approval
October 19, 2026 14:10 — with
GitHub Actions
Active
GitHub Actions
Active
Contributor
|
Documentation preview for this pull request is available at: |
1 task
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #706
When building score/lifecycle with
--features=all_wall_warnings, we see an error in baselibs:We're fixing this by adding the missing braces. Without the extra braces we're relying on brace elision.