Repository navigation
feat(bzlmod-lock-check): verify bazel lockfile - #122
Merged
Merged
Conversation
…rd against pull_request_target - Split single job into bzlmod-tidy-check and bzlmod-lockfile-check so both results are reported independently in the PR checks UI - Add `bazel mod deps --lockfile_mode=error` to verify the committed lockfile matches the resolved dependency graph - Add explicit guard step that fails (not skips) when called from pull_request_target, which would otherwise run Bazel on untrusted fork code with access to repository secrets - Remove unsafe fork checkout (head_ref + fork repository override) in favor of the default checkout, which is safe for pull_request and schedule events - Add header documentation with pre-commit alternative and security note - Update README section 16 to reflect both jobs, the security constraint, and the pre-commit recommendation
AlexanderLanin
requested review from
MaximilianSoerenPollak,
PiotrKorkus,
dcalavrezo-qorix,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
June 8, 2026 20:49
PiotrKorkus
approved these changes
Jun 8, 2026
PiotrKorkus
left a comment
PiotrKorkus
left a comment
Contributor
There was a problem hiding this comment.
lgtm, as discussed in todays meeting this is a good change to actually verify lockfile
odra
approved these changes
Jun 8, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in INF - Infrastructure Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified:
Recommendation:
Run this job from your on-pr.yml or even better don't, and handle the use-case via pre-commit
Resolves #123