Skip to content

feat: add published doc link in the Actions UI - #230

Merged
AlexanderLanin merged 8 commits into
eclipse-score:mainfrom
etas-contrib:feature/add-url-to-the-action-UI
Oct 13, 2026
Merged

AlexanderLanin merged 8 commits into
eclipse-score:mainfrom
etas-contrib:feature/add-url-to-the-action-UI

Conversation

@vibhoraggarwal

Copy link
Copy Markdown
Contributor

Adds the url to the published pages on the Actions UI of the workflow

@AlexanderLanin

Copy link
Copy Markdown
Member

Do you have an example of what this will look like? e.g. screenshot
Does that imply that we need to establish github-pages environment for all repos?
That url will not point to the PR preview, but the general docs, so whats the point?

@MaximilianSoerenPollak

Copy link
Copy Markdown
Contributor

Do you have an example of what this will look like? e.g. screenshot Does that imply that we need to establish github-pages environment for all repos? That url will not point to the PR preview, but the general docs, so whats the point?

Reiterating this point here.
Can you answer this question? @vibhoraggarwal @av-etas

@vibhoraggarwal

vibhoraggarwal commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Do you have an example of what this will look like? e.g. screenshot Does that imply that we need to establish github-pages environment for all repos? That url will not point to the PR preview, but the general docs, so whats the point?

image

Yes, it should publish the deployed URL in the summary with the current change.
Although this is a simple change it could not possibly be done by workflows calling this workflows as they do not have access to the output of deploy-page job (which is a part of this workflow).

Motivation: It makes it easier to see where the documentation gets deployed with the current workflow and the user does not have to find it themselves.

That url will not point to the PR preview, but the general docs, so whats the point?

If a PR or a feature triggers the workflow the url would be pointed to the link referring to that link

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

URL handling introduces shell injection risk and breaks preview links for legacy deployments.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds published documentation URLs to GitHub Actions output and PR comments.

Changes:

  • Adds the deployment URL to the job summary.
  • Uses the deployment output URL in preview comments.
File summaries
File Description
.github/workflows/docs-publish.yml Publishes deployment links in summaries and PR comments.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/docs-publish.yml Outdated
Comment thread .github/workflows/docs-publish.yml Outdated
@AlexanderLanin

Copy link
Copy Markdown
Member

@vibhoraggarwal can you have a look at the suggestions? They look reasonable to me.

@vibhoraggarwal
vibhoraggarwal force-pushed the feature/add-url-to-the-action-UI branch from f7c2ef4 to 296626b Compare September 17, 2026 09:51
@vibhoraggarwal

Copy link
Copy Markdown
Contributor Author

@AlexanderLanin Now, I am using those suggestions.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Legacy deployments omit the summary, and deployment URLs may be malformed when the base URL lacks a trailing slash.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Resolved since last review (2)

Comment thread .github/workflows/docs-publish.yml Outdated
@AlexanderLanin
AlexanderLanin marked this pull request as draft September 22, 2026 10:48
@AlexanderLanin

Copy link
Copy Markdown
Member

New PR overview attempt: Please mark the PR as ready for review once AI feedback is commented OR fixed, and resolved.

@vibhoraggarwal
vibhoraggarwal force-pushed the feature/add-url-to-the-action-UI branch from c8c85e4 to fe9b687 Compare October 1, 2026 20:10
@vibhoraggarwal
vibhoraggarwal marked this pull request as ready for review October 1, 2026 20:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The URL fallback covers legacy deployments and the resolved output is consistently reused.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@AlexanderLanin AlexanderLanin changed the title code: add published doc link in the Actions UI feat: add published doc link in the Actions UI Oct 13, 2026
@AlexanderLanin
AlexanderLanin merged commit 6e412c7 into eclipse-score:main Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

5 participants