Repository navigation
fix(qnx-build): support matrix and nested workspace test logs - #248
Merged
Merged
Conversation
Allow callers to choose unique test-log artifact names while preserving the existing default. Collect logs relative to the configured working directory. Signed-off-by: Andrey Babanin <andrey.babanin@bmw.de> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4og
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
PiotrKorkus,
dcalavrezo-qorix,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
October 12, 2026 13:58
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused workflow and documentation changes correctly address both reported artifact-upload limitations.
0 open findings
What changed in this PR
Adds matrix-safe, nested-workspace test-log uploads to the reusable QNX build workflow.
Changes:
- Adds a configurable test-log artifact name.
- Resolves test logs relative to the configured working directory.
- Documents matrix and rerun naming requirements.
| File | Description |
|---|---|
.github/workflows/qnx-build.yml |
Adds artifact-name input and nested-workspace upload path. |
README.md |
Documents test-log naming and upload behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AlexanderLanin
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The QNX workflow currently uploads every invocation's test logs as
qnx-testlogs.Matrix builds with tests enabled cannot reliably use this upload step because multiple jobs try to create the same artifact in one workflow run.
GitHub rejects the duplicate artifact name, so an otherwise passing build can fail during log upload.
The upload path is also fixed to the repository root.
When
working-directorypoints to another Bazel workspace, such asexamples/integration, its test logs are not collected.These two limitations block adopting the workflow in
eclipse-score/baselibs, which runs QNX tests in a matrix covering both the root and integration workspaces.Changes
test-log-artifact-nameinput, defaulting toqnx-testlogsto preserve the existing artifact name for callers that omit it.working-directory.For example, Baselibs can supply a distinct name for each matrix leg and run attempt: