Repository navigation
docs: link and typo - #1009
Merged
Merged
docs: link and typo#1009
Conversation
vibhoraggarwal
commented
Aug 25, 2026
vibhoraggarwal
commented
- A file link in readme
- Typo in readme
vibhoraggarwal
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
August 25, 2026 23:19
LittleHuba
reviewed
Aug 26, 2026
| ## Overview | ||
|
|
||
| `LoLa`/`mw::com`: A high-level communication middleware as a partial implementation of the Adaptive AUTOSAR | ||
| `LoLa`/`mw::com`: A high-level communication middleware is a partial implementation of the Adaptive AUTOSAR |
Contributor
There was a problem hiding this comment.
This sentence is still quite hard to read.
A high-level communication middleware and partial implementation of the Adaptive AUTOSAR would make it more clear IMO.
Author
There was a problem hiding this comment.
Now, I tried to rephrase the description to make it more understandable.
|
|
||
| Documentation of `mw::com`s public API with usage examples can be found in `doc/user_facing_API_examples.md`. | ||
| If you want to see an example app, which uses LoLa to establish shared-memory communication between a service and a | ||
| Documentation of `mw::com`s public API with usage examples can be found in [doc/user_facing_API_examples.md](doc/user_facing_API_examples.md). If you want to see an example app, which uses LoLa to establish shared-memory communication between a service and a |
Contributor
There was a problem hiding this comment.
Please keep the separated lines.
Suggested change
| Documentation of `mw::com`s public API with usage examples can be found in [doc/user_facing_API_examples.md](doc/user_facing_API_examples.md). If you want to see an example app, which uses LoLa to establish shared-memory communication between a service and a | |
| Documentation of `mw::com`s public API with usage examples can be found in [doc/user_facing_API_examples.md](doc/user_facing_API_examples.md). | |
| If you want to see an example app, which uses LoLa to establish shared-memory communication between a service and a |
vibhoraggarwal
force-pushed
the
feature/link-and-typo
branch
from
August 26, 2026 08:11
4a9a816 to
61a4fcf
Compare
vibhoraggarwal
force-pushed
the
feature/link-and-typo
branch
from
August 26, 2026 08:14
61a4fcf to
f9b17e1
Compare
castler
approved these changes
Aug 26, 2026
castler
enabled auto-merge
August 26, 2026 18:58
github-project-automation
Bot
moved this from Backlog
to Done
in COM - Communication FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.