Repository navigation
Rust::com Rust target edition removes and rustfmt fix - #1050
LittleHuba merged 2 commits into
Conversation
* Use the Score Rust toolchain's default edition instead of specifying the edition on each Rust Bazel target.
bharatGoswami8
changed the title
limdor
left a comment
limdor
left a comment
There was a problem hiding this comment.
In e30a1be the commit message should be extended that explains what you did for reformatting. In this way the reviewer can rerun the command and see if there are any issues.
Also I'm a bit skeptical of formatting without enforcing it. Can you explain why you are reformatting in this PR? It would make more sense to do it in the PR that also introduce the enforcement otherwise it is a matter of time that it is wrongly formatted again
ab898e2
About 3f0830a you should explain in the commit message how you are fixing not just saying that it fixes an issue. It is ok to mention that this is an issue found by clippy but you as well as the reviewer (communicated via commit message) should understand why the change is done and how this is better than before.
- Initialize default structs without field reassignment. - Resolve the temporary lifetime issue in the mock allocator. - Add the missing score_com dependency for concept tests.
3f0830a to
8f24c40
Compare
The rustfmt fix was with configuration setup changes only but I agree that including it in the configuration PR would be more aligned. I have also updated the commit message for the clippy fix. |
the edition on each Rust Bazel target.