Repository navigation
lola/messaging: declare missing safe_math dependency - #1089
Merged
limdor merged 1 commit intoSep 15, 2026
Merged
Conversation
mihajlo-k
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
September 15, 2026 10:29
Contributor
|
Because it is used only in cpp, please add it to implementation deps |
message_passing_service_instance.cpp includes score/language/safecpp/safe_math/safe_math.h, but the target did not declare the dependency. It resolved only transitively through score/json:json_writer_impl -> score/json/internal/writer/json_serialize. Any change to the json writer's dependency graph therefore breaks this target with "safe_math.h: No such file or directory". All other targets in the repo that include this header already declare the dependency.
mihajlo-k
force-pushed
the
mk_missing_safe_math_dependency
branch
from
September 15, 2026 10:54
91ee48a to
fdcf964
Compare
limdor
approved these changes
Sep 15, 2026
Merged
via the queue into
eclipse-score:main
with commit Sep 15, 2026
a98fa87
23 of 24 checks passed
github-project-automation
Bot
moved this from Backlog
to Done
in COM - Communication FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
message_passing_service_instance.cppincludesscore/language/safecpp/safe_math/safe_math.h, but the target did not declare the dependency. It resolved only transitively throughscore/json:json_writer_impl->score/json/internal/writer/json_serialize.Any change to the json writer's dependency graph therefore breaks this target with "safe_math.h: No such file or directory". All other targets in the repo that include this header already declare the dependency.