Repository navigation
FTA for failure mode regarding code and mw::config out of sync - #1143
Merged
Merged
Conversation
SebSparrowHawk
force-pushed
the
ssp_fta_code_config
branch
2 times, most recently
from
September 24, 2026 07:02
4ae1e07 to
442a16d
Compare
SebSparrowHawk
force-pushed
the
ssp_fta_code_config
branch
2 times, most recently
from
October 6, 2026 13:10
d9459bd to
c7b5ee0
Compare
SebSparrowHawk
marked this pull request as ready for review
October 6, 2026 13:39
SebSparrowHawk
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
October 6, 2026 13:39
SebSparrowHawk
force-pushed
the
ssp_fta_code_config
branch
2 times, most recently
from
October 7, 2026 11:01
3d5e744 to
2f67157
Compare
crimson11
requested changes
Oct 8, 2026
| // mitigates = "GeneratedCodeDoesNotMatchGenerationInputs" | ||
| description = "Input artifacts shall be manually reviewed for correctness" | ||
| ScoreReq.AoU ArtifactsRequireManualReview { | ||
| description = "Input artifacts (proxy/skeleton code and mw::config) shall be manually reviewed for correctness" |
Contributor
There was a problem hiding this comment.
The input artefacts (which aragen generated) is the C++ service-interface definition. (not proxy/skeleton).
So - I guess regarding the config, we already have AoU?
So here you should just talk about the service-interface definition.
Contributor
Author
There was a problem hiding this comment.
I checked and there is no dedicated AoU for the configuration (review).
I would therefore keep this AoU for both parts.
I adapted the description so that it's not calling it proxy/skeleton code but C++ service-interface definitions.
Since this AoU is also not aragen (or code generators in general) specific, I think it can handle all input artifacts.
| ScoreReq.FailureMode CodeDoesNotMatchConfiguration { | ||
| guidewords = [ ScoreReq.Guideword.UnintendedFunction ] | ||
| description = "Proxys and Skeletons as data-types are generated using the aragen and not handwritten, may not match to the input (Meta-Model)." | ||
| description = "Definitions of proxies, skeletons and data-types may not match the given mw::com configuration." |
Contributor
There was a problem hiding this comment.
see above -> service-.interface definition may not match ...
Contributor
Author
There was a problem hiding this comment.
Adapted this part.
SebSparrowHawk
force-pushed
the
ssp_fta_code_config
branch
3 times, most recently
from
October 14, 2026 08:00
7ab1511 to
65598b6
Compare
crimson11
previously approved these changes
Oct 14, 2026
SebSparrowHawk
force-pushed
the
ssp_fta_code_config
branch
2 times, most recently
from
October 15, 2026 06:50
5097d03 to
b1067e0
Compare
SebSparrowHawk
force-pushed
the
ssp_fta_code_config
branch
from
October 15, 2026 07:14
b1067e0 to
35e76a0
Compare
crimson11
approved these changes
Oct 16, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in COM - Communication FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.