Repository navigation
fix(misra): remove noexcept from further functions that can propagate exceptions (RULE-18-5-1) - #1232
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
castler
force-pushed
the
fix/misra-rule-18-5-1-followup
branch
from
October 1, 2026 07:27
bdfb44d to
a4a4477
Compare
castler
marked this pull request as ready for review
October 2, 2026 05:30
castler
requested review from
LittleHuba,
bemerybmw,
crimson11,
hoe-jo and
limdor
as code owners
October 2, 2026 05:30
castler
enabled auto-merge
October 2, 2026 05:30
castler
force-pushed
the
fix/misra-rule-18-5-1-followup
branch
from
October 2, 2026 07:18
a4a4477 to
caadc5e
Compare
… exceptions (RULE-18-5-1) Follow-up to the previous RULE-18-5-1 fix addressing newly reported findings (SkeletonEvent::Send/Notify, Configuration::Validate/GetElementNamesOfServiceType, LinearSearchMap::find, GenericProxy move assignment, ProxyFieldBase subscription functions, SkeletonBase::StopOfferService and the skeleton event/field binding factories). Declarations, interface bases and mocks are kept in sync. The implicitly noexcept ~GenericProxy keeps noexcept and is covered by the existing destructor deviation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
crimson11
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for new CodeQL findings of
cpp/misra/noexcept-function-should-not-propagate-to-the-caller.noexceptfrom the flagged functions (declarations, interface bases, overrides and mocks kept in sync) and from thin wrappers calling them.~GenericProxykeepsnoexceptand is added to the existing destructor deviation.Verified: unit tests for impl, lola, plumbing and configuration pass. CodeQL not re-run locally.