Repository navigation
Conversation
Set readability-function-cognitive-complexity.IgnoreMacros to true so that control flow introduced by macro expansions (e.g. gtest/assert macros) no longer inflates a function's complexity score. The score then reflects only the code a reader actually sees in the function body. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
castler
marked this pull request as ready for review
October 2, 2026 05:28
castler
requested review from
LittleHuba,
bemerybmw,
crimson11,
hoe-jo and
limdor
as code owners
October 2, 2026 05:28
castler
enabled auto-merge
October 2, 2026 06:49
crimson11
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets
readability-function-cognitive-complexity.IgnoreMacros: truein.clang-tidy. Control flow that comes from macro expansions (test/assert macros, etc.) no longer inflates a function's cognitive complexity, so the score reflects the code that is actually written in the function body.Effect
A local clang-tidy run over
//score/...reports 7 distinctreadability-function-cognitive-complexityfindings with this option, compared to 28 open code-scanning alerts for this check onmainbefore.