Repository navigation
refactor(tutorial): replace snprintf with std::copy_n in providers - #1277
Merged
Merged
Conversation
Build the payload as a std::string and copy it into the sample array with std::copy_n, truncating to the array capacity and null-terminating. This removes the snprintf/memcpy calls and the pointer arithmetic, and with them the cppcoreguidelines-pro-type-vararg and pro-bounds-pointer-arithmetic clang-tidy findings, while simplifying the tutorial code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
crimson11
previously approved these changes
Oct 5, 2026
castler
marked this pull request as ready for review
October 5, 2026 12:42
castler
requested review from
LittleHuba,
bemerybmw,
hoe-jo and
limdor
as code owners
October 5, 2026 12:42
castler
enabled auto-merge
October 5, 2026 12:42
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
crimson11
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
std::snprintf+memcpy+ pointer arithmetic in the tutorial providers (chapters 1, 2, 6, 10, 12) with astd::stringpayload copied viastd::copy_n(truncated to capacity, null-terminated).printf-style error handling needed.cppcoreguidelines-pro-type-varargandpro-bounds-pointer-arithmeticfindings for these files (clang-tidy clean on the touched files)."Hello World" + counter.Chapters 3-5 already build a
std::stringand usememcpy; not touched.