Repository navigation
fix(clang-tidy): avoid unnecessary handle copies in sample sender/receiver - #1293
Conversation
Review Checklist Evidence Notice - Merge QueueThis pull request is (or recently was) in the merge queue. Checklist evidence (the description, an acknowledgement reply, an approving review, or a commit) Once this pull request is merged, prefer the evidence recorded in git history over this description |
…eiver Bind the service handle by const reference instead of copying it, resolving performance-unnecessary-copy-initialization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Binds
handlebyconst auto&in 4 places insample_sender_receiver.cppinstead of copying it, fixing the remaining 4performance-unnecessary-copy-initializationalerts.handle_resultoutlives each reference.--config=cibuild of//score/mw/com/test/...passes.Review Checklist Evidence Notice - Merge Queue
This pull request is (or recently was) in the merge queue.
A pull request may only enter the merge queue when all necessary review checklist acknowledgements are in place.
Checklist evidence (the description, an acknowledgement reply, an approving review, or a commit)
changed after this pull request entered the merge queue.
The evidence visible here may no longer reflect what was true at merge-queue entry.
Once this pull request is merged, prefer the evidence recorded in git history over this description
where the two differ — the description keeps updating live for as long as this PR exists, while the
merge commit (if your merge-queue configuration embeds the PR title and description into it) is a
fixed, tamper-evident record of what was true at that point.