Repository navigation
Add phase 1 FTA's for Subscribe and Unsubscribe - #1307
Conversation
| version = 1 | ||
| safety = ScoreReq.Asil.B | ||
| rationale = "All four root causes have been prevented by according measures each. * The name mapping clash in case of a GenericProxy is prevented by: ''Service-Element-Name clash needs to get unambigiously detected.'' * The referencing of wrong storage location is prevented by: ''Mapping from Event/Field identification to shared-memory storage needs to be unambigous.''" | ||
| interface = "score.mw.com.GenericProxyEvent.Subscribe" |
There was a problem hiding this comment.
I would say that it's not just GenericProxyEvent that is affected by these failures, but all proxy events and therefore argue to add "score::mw::com::AsProxy" as an interface.
I think you can't add more than one interface entry, right?
There was a problem hiding this comment.
According to tooling interface is optional String, single-valued, so only one entry is possible.
The system interface or signal that is affected by this failure mode.
According to public_api.puml and api_surface.lock.json Subscribe is declared on GenericProxyEvent and this is the architectural representative for all proxy-event flavours IMHO. Please correct me if I am wrong
There was a problem hiding this comment.
No. We have Subscribe on GenericSkeletonEvent and SkeletonEvent<SampleType>
See our discussion/meeting today after the daily. Also the signature shall be C++! I.e :: instead of ..
Get in touch with Jochen, if it does not work.
There was a problem hiding this comment.
I did that yesterday with good intentions; if it's blocking the PR now, I'll revert it.
This entire file needs to be revised anyway concerning the interface name.
There was a problem hiding this comment.
Let's fix it in the next step.
There was a problem hiding this comment.
I have just checked it with interface = "score::mw::com:GenericProxyEvent::SetReceiveHandler" and the Lobster tracing does not work anymore
There was a problem hiding this comment.
No. We have
SubscribeonGenericSkeletonEventandSkeletonEvent<SampleType>See our discussion/meeting today after the daily. Also the signature shall be C++! I.e::instead of.. Get in touch with Jochen, if it does not work.
you mean Proxy instead of Skeleton for Subscribe, right?
Also, here's a question: If two APIs are available and only one of them can be linked, how can this be resolved?
However, this must be addressed in follow-ups. So revert, or it can be merged as is for now?
There was a problem hiding this comment.
reverted all changes in this file
7953409 to
e63b5af
Compare
Add phase 1 FTA's for Subscribe and Unsubscribe