Repository navigation
Add fta for SucceedsDespiteAnError - #1311
Merged
crimson11 merged 1 commit intoOct 12, 2026
Merged
Conversation
cdemirsoy
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
October 6, 2026 16:07
cdemirsoy
force-pushed
the
cd_add_fta_success_despite_an_error
branch
5 times, most recently
from
October 8, 2026 07:56
7bbb9ab to
83f1a3b
Compare
crimson11
previously approved these changes
Oct 8, 2026
crimson11
enabled auto-merge
October 8, 2026 08:41
auto-merge was automatically disabled
October 8, 2026 10:13
Head branch was pushed to by a user without write access
cdemirsoy
force-pushed
the
cd_add_fta_success_despite_an_error
branch
2 times, most recently
from
October 9, 2026 07:09
fe54e88 to
ba8af47
Compare
cdemirsoy
force-pushed
the
cd_add_fta_success_despite_an_error
branch
from
October 9, 2026 07:31
ba8af47 to
cfe7ece
Compare
crimson11
requested changes
Oct 9, 2026
|
|
||
| !include fta_metamodel.puml | ||
|
|
||
| $FailureMode("Succeeds despite an error", "Communication.SucceedsDespiteAnError") |
Contributor
There was a problem hiding this comment.
Can you "rename" the failure-mode? In our flat tlrc structure SucceedsDespiteAnError nobody knows, what this is ...
So - GetNewSamplesSucceedsDespiteAnError is better ...
cdemirsoy
force-pushed
the
cd_add_fta_success_despite_an_error
branch
2 times, most recently
from
October 9, 2026 10:21
e130ebc to
32b6071
Compare
cdemirsoy
force-pushed
the
cd_add_fta_success_despite_an_error
branch
from
October 9, 2026 10:21
32b6071 to
171d921
Compare
crimson11
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an interim (Phase 1) FTA for the failure mode Communication.GetNewSamplesSucceedsDespiteAnError, with a single root cause. This resolves "missing reference to Root Causes" for this failure mode in the traceability report.
It also renames the failure mode SucceedsDespiteAnError → GetNewSamplesSucceedsDespiteAnError, because the old name doesn't say which API it refers to in the flat TRLC namespace. The root cause is renamed the same way.
Before (main)
[MISSING] TRLC Failuremode Communication.SucceedsDespiteAnError: missing reference to Root Causes; unknown tracing target req mw.com.Event.GetNewSamplesroot causes: 0
After (cd_add_fta_success_despite_an_error)
"missing reference to Root Causes" resolved: Communication.GetNewSamplesSucceedsDespiteAnError → mw_com_fta.RootCauseGetNewSamplesSucceedsDespiteAnError[PARTIAL] TRLC Rootcause mw_com_fta.RootCauseGetNewSamplesSucceedsDespiteAnErrorroot causes: 1
The failure mode stays [MISSING] because of the existing interface = "mw.com.Event.GetNewSamples", which doesn't match any element in the architectural design. That was already the case on main.