Repository navigation
fix(clang-tidy): use dynamic_cast for downcast in HandleResponse - #1316
Merged
Merged
Conversation
castler
changed the title
castler
force-pushed
the
fix_static_cast_downcast
branch
from
October 7, 2026 09:02
0003e08 to
85707c4
Compare
castler
marked this pull request as ready for review
October 7, 2026 09:07
castler
requested review from
LittleHuba,
bemerybmw,
crimson11,
hoe-jo and
limdor
as code owners
October 7, 2026 09:07
castler
enabled auto-merge
October 7, 2026 09:07
crimson11
approved these changes
Oct 7, 2026
Replace the static_cast downcast with dynamic_cast plus a null check, matching how QemuHypervisorTransport handles the same message types. The null check also replaces the former GetType() comparison. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
cppcoreguidelines-pro-type-static-cast-downcastinBidirectionalTransport::HandleResponseby usingdynamic_castwith a null check (same pattern asQemuHypervisorTransport) instead of a suppression. The null check replaces the previousGetType()comparison.Verified:
--config=cibuild and all sample transport tests pass.