Skip to content

Link RootCauseReturnsWrongFreeSampleCount to CompReq CalculationOfFreeSampleCount - #1350

Open
cdemirsoy wants to merge 1 commit into
eclipse-score:mainfrom
cdemirsoy:cd_add_safety_measure_free_sample_count
Open

cdemirsoy wants to merge 1 commit into
eclipse-score:mainfrom
cdemirsoy:cd_add_safety_measure_free_sample_count

Conversation

@cdemirsoy

@cdemirsoy cdemirsoy commented Oct 8, 2026 •

Copy link
Copy Markdown

Link RootCauseReturnsWrongFreeSampleCount to CompReq CalculationOfFreeSampleCount

  • Link mw_com_fta.RootCauseReturnsWrongFreeSampleCount to the existing CompReq CalculationOfFreeSampleCount (SCR-21803116) via derived_from, instead of adding a Mitigation
  • Add AssigningNullptrToSamplePtrIncrementsFreeSampleCount in proxy_event_test.cpp, the only part of the requirement that had no test
  • Add lobster-tracing: Communication.CalculationOfFreeSampleCount to the new test and to the existing SamplePtrLimitsAreEnforced, so all parts of the requirement trace to the CompReq

The root cause will stay [PARTIAL] until mw::com has a component(...) target in dependable_element.components

@cdemirsoy
cdemirsoy force-pushed the cd_add_safety_measure_free_sample_count branch 2 times, most recently from 53d4bc6 to e88aeae Compare October 9, 2026 07:09
@cdemirsoy
cdemirsoy marked this pull request as ready for review October 13, 2026 08:09
@cdemirsoy
cdemirsoy force-pushed the cd_add_safety_measure_free_sample_count branch from e88aeae to 3f81589 Compare October 13, 2026 08:09
@@ -0,0 +1,25 @@
/********************************************************************************

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify with Jochen:

I would name the file mitigations.tlrc!
Naming it safetymeasures.tlrc makes no sense to me! Also AoUs and component-rey may be "safety measures" and they are each in their own file - named accordingly!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitting this solution for now.

import mw_com_fta

// mitigates = "ReturnsWrongFreeSampleCount"
ScoreReq.Mitigation FreeSampleCountCalculationSpecifiedAndTested {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So - is this just an arbitrary sample? Because for this root cause I would NOT come up with a mitigation, but with a component req. instead, which can be tested....
I.e. "mitigations" are the "last resort", when we don't have a comp.req. which we can test and we also do not have an AoU, which can handle the issue.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I will follow this way.

@cdemirsoy
cdemirsoy force-pushed the cd_add_safety_measure_free_sample_count branch 2 times, most recently from 34f4926 to 59a413c Compare October 15, 2026 13:38
@cdemirsoy
cdemirsoy force-pushed the cd_add_safety_measure_free_sample_count branch from 59a413c to 604f6ce Compare October 19, 2026 07:01
@cdemirsoy cdemirsoy changed the title Add mitigation for RootCauseReturnsWrongFreeSampleCount Link RootCauseReturnsWrongFreeSampleCount to CompReq CalculationOfFreeSampleCount Oct 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants