Skip to content

Do not mix different versions of ferrocene toolchain builder - #1370

Merged
limdor merged 1 commit into
eclipse-score:mainfrom
limdor:ferrocene
Oct 15, 2026
Merged

limdor merged 1 commit into
eclipse-score:mainfrom
limdor:ferrocene

Conversation

@limdor

@limdor limdor commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Using different versions of the toolchain builders adds unnecessary risk.
We are not aware of any good reasons why someone would like to use different versions of the builder or using different commit hashes in the same build tree.

@limdor limdor added the test-qnx Enables the checks with QNX toolchains. Checks require committer approval to start execution. label Oct 13, 2026
Using different versions of the toolchain builders adds unnecessary
risk.
We are not aware of any good reasons why someone would like to use
different versions of the builder or using different commit hashes
in the same build tree.
@limdor

limdor commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor Author

@dcalavrezo-qorix you created the PR updating coverage without updating the other. Do you see a good reason why someone would want to use a different version of ferrocene toolchain builder for coverage than for the rest?

@limdor
limdor enabled auto-merge October 13, 2026 07:07
@dcalavrezo-qorix

Copy link
Copy Markdown
Contributor

@dcalavrezo-qorix you created the PR updating coverage without updating the other. Do you see a good reason why someone would want to use a different version of ferrocene toolchain builder for coverage than for the rest?

this wasn't intentional. it's harmful since all versions are based on the same ferrocene commit SHA.

so there's no good reason.

Btw, I think we should switch to 1.3.1

FERROCENE_TOOLCHAIN_BUILDER_VERSION = "1.3.1"
...
coverage_tools_sha256 = "9cf5d76b2e505bf2a8b2b47c60f191ac1273f87851ed387e53080b8e5d14dedf",
...
sha256 = "6fd7c7053a80463b2bfd24202de02e16959b18ed185c55b738148e9caac42eff",

@limdor

limdor commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

@dcalavrezo-qorix you created the PR updating coverage without updating the other. Do you see a good reason why someone would want to use a different version of ferrocene toolchain builder for coverage than for the rest?

this wasn't intentional. it's harmful since all versions are based on the same ferrocene commit SHA.

so there's no good reason.

Btw, I think we should switch to 1.3.1

FERROCENE_TOOLCHAIN_BUILDER_VERSION = "1.3.1"
...
coverage_tools_sha256 = "9cf5d76b2e505bf2a8b2b47c60f191ac1273f87851ed387e53080b8e5d14dedf",
...
sha256 = "6fd7c7053a80463b2bfd24202de02e16959b18ed185c55b738148e9caac42eff",

Thanks for the feedback. About updating to 1.3.1, I did not do because I did not want to do too many changes at once, but I can do it in a follow up.

@limdor
limdor added this pull request to the merge queue Oct 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 14, 2026
@limdor
limdor added this pull request to the merge queue Oct 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 14, 2026
@limdor
limdor added this pull request to the merge queue Oct 15, 2026
Merged via the queue into eclipse-score:main with commit 0d70bd4 Oct 15, 2026
18 checks passed
@limdor
limdor deleted the ferrocene branch October 15, 2026 14:49
@github-project-automation github-project-automation Bot moved this from Backlog to Done in COM - Communication FT Oct 15, 2026

This branch was successfully deployed

1 active deployment
workflow-approval — b4d1c0b7 Deployed Oct 13, 2026 by limdor via approval #6504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-qnx Enables the checks with QNX toolchains. Checks require committer approval to start execution.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants