Repository navigation
Link GetNewSamples error root cause to GetNewSamplesReturnsErrorInsteadOfSampleCount - #1413
Open
cdemirsoy wants to merge 1 commit into
Conversation
cdemirsoy
changed the title
cdemirsoy
marked this pull request as ready for review
October 20, 2026 06:32
cdemirsoy
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
October 20, 2026 06:32
cdemirsoy
changed the title
cdemirsoy
force-pushed
the
cd_add_safety_measure_get_new_samples_succeeds_despite_error
branch
from
October 22, 2026 08:55
898bd69 to
cb5935a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link RootCauseGetNewSamplesSucceedsDespiteAnErrorto CompReq GetNewSamplesReturnsErrorInsteadOfSampleCount
Link the dangling root cause RootCauseGetNewSamplesSucceedsDespiteAnError to a new component requirement, GetNewSamplesReturnsErrorInsteadOfSampleCount, instead of a mitigation
Existing tests already verify every error path of GetNewSamples, so they are now tagged with the new requirement
The root cause will still show as uncovered in the mw_com report until mw::com has a component target that includes component_requirements_ipc and the tests.