Skip to content

'Release' does not work 'external filter' #31

Closed

Description

@MaximilianSoerenPollak

Building the 'release' type of documentation does not respect the 'is_external' filter while it's building the 'needs.json'.
The reason is that at that moment, the imported 'module' is not external and is just building itself. Therefore the module has to NOT have any build errors / warnings, otherwise it will exit with an error => therefore the target after it (the one in our BUILD file) is not execute and won't run.

Best course of action is just to have modules that do not have errors in them :D I guess.

Just leaving this up here as a reminder.

Activity

  1. AlexanderLanin commented on May 22, 2025

    @AlexanderLanin
    Member

    Released modules cannot have errors?! What's the problem?

  2. MaximilianSoerenPollak commented on May 22, 2025

    @MaximilianSoerenPollak
    ContributorAuthor

    I have to double check this as I already forgot somewhat.

    But what I saw if I remember correctly was that the build from the module itself succeeded, but then the module as a target failed, without changing the underlying code.

    But this might be a nonissue anymore.

  3. MaximilianSoerenPollak commented on May 26, 2025

    @MaximilianSoerenPollak
    ContributorAuthor

    Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions