Repository navigation
test: fully verify tool_req__docs_req_arch_link_safety_to_arch - #909
Merged
a-zw merged 1 commit intoOct 7, 2026
Merged
Conversation
a-zw
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
October 5, 2026 10:58
Contributor
|
Documentation preview for this pull request is available at: |
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Questions.
| tool_req__docs_req_arch_link_safety_to_arch: | ||
| needs: | ||
| include: feat_arc_sta, logic_arc_int, logic_arc_int_op, comp_arc_sta, real_arc_int, real_arc_int_op | ||
| include: feat_arc_sta, logic_arc_int, logic_arc_int_op, comp_arc_sta, real_arc_int, real_arc_int_op, comp |
Contributor
There was a problem hiding this comment.
feat missing?
Contributor
Author
There was a problem hiding this comment.
In theory, gd_req__arch_build_blocks defines what is an arch element. It also includes mod. That would mean, we have to extend tool_req__docs_arch_types.
However, we suspect this is inconsistent with other requirements (mod has no safety option?).
a-zw
force-pushed
the
fully-verify-arch-link-safety
branch
from
October 6, 2026 07:39
4fe2c12 to
740de81
Compare
MaximilianSoerenPollak
approved these changes
Oct 7, 2026
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Improves coverage.
🚨 Impact Analysis
✅ Checklist