Skip to content

Update FMEA attribute name #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximilianSoerenPollak merged 7 commits into from
Oct 8, 2026
Merged

Update FMEA attribute name #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f160935
update root_cause to failure_root_cause within fmea and dfa
janis-qorix Oct 5, 2026
1e46ab1
req version update
janis-qorix Oct 6, 2026
209b54c
Merge branch 'main' into janisqrx_update_saf_analysis
janis-qorix Oct 7, 2026
bf204a0
Merge branch 'main' into janisqrx_update_saf_analysis
PandaeDo Oct 8, 2026
5b72075
Merge branch 'main' into janisqrx_update_saf_analysis
PandaeDo Oct 8, 2026
97786c5
reset req version
janis-qorix Oct 8, 2026
59eeb96
Merge branch 'main' into janisqrx_update_saf_analysis
PandaeDo Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/internals/requirements/requirements.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,7 @@ Safety Analysis (DFA + FMEA) Process to Tool Requirement Mapping
:parent_covered: YES

Docs-As-Code shall allow FMEA needs (``feat_saf_fmea``, ``comp_saf_fmea``)
to have an optional ``root_cause`` attribute with non-empty content.
to have an optional ``failure_root_cause`` attribute with non-empty content.


🔒 Security Analysis
Expand Down
4 changes: 2 additions & 2 deletions src/extensions/score_metamodel/metamodel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,7 @@ needs_types:
# req-Id: tool_req__docs_saf_attrs_safety_relevant
safety_relevant: ^(yes|no)$
# req-Id: tool_req__docs_saf_attrs_root_cause
root_cause: ^[\s\S]+$
failure_root_cause: ^[\s\S]+$
mitigation_issue: ^https://github\.com/[^/]+/[^/]+/issues/\d+$
mandatory_links:
# req-Id: tool_req__docs_saf_attrs_violates
Expand Down Expand Up @@ -878,7 +878,7 @@ needs_types:
optional_options:
# req-Id: tool_req__docs_saf_attrs_mitigation_issue
safety_relevant: ^(yes|no)$
root_cause: ^[\s\S]+$
failure_root_cause: ^[\s\S]+$
mitigation_issue: ^https://github\.com/[^/]+/[^/]+/issues/\d+$
mandatory_links:
# req-Id: tool_req__docs_saf_attrs_violates
Expand Down
6 changes: 3 additions & 3 deletions src/extensions/score_metamodel/tests/rst/safety/test_saf_optional_attrs.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
Tests optional attributes for safety analysis types:
- mitigation_issue: GitHub issue URL pattern
- safety_relevant: yes/no for all SAF types
- root_cause: non-empty content for FMEA
- failure_root_cause: non-empty content for FMEA


.. feat_saf_dfa:: Valid mitigation issue
Expand Down Expand Up @@ -86,7 +86,7 @@
:failure_effect: component failure
:sufficient: no
:status: valid
:root_cause: manufacturing defect in solder joints
:failure_root_cause: manufacturing defect in solder joints
:expect_not: need_id


Expand All @@ -97,5 +97,5 @@
:failure_effect: software crash
:sufficient: yes
:status: valid
:root_cause: null pointer dereference in interrupt handler
:failure_root_cause: null pointer dereference in interrupt handler
:expect_not: need_id
18 changes: 9 additions & 9 deletions src/tests/docs_bzl/scenarios/basic_docs/_expected/needs_json/needs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,15 @@
"null"
]
},
"failure_root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"fault_id": {
"default": "",
"description": "Added by needs_fields config",
Expand Down Expand Up @@ -1054,15 +1063,6 @@
"null"
]
},
"root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"safety": {
"default": "",
"description": "Added by needs_fields config",
Expand Down
18 changes: 9 additions & 9 deletions src/tests/docs_bzl/scenarios/data_files_runfiles/_expected/data_bundle_needs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,15 @@
"null"
]
},
"failure_root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"fault_id": {
"default": "",
"description": "Added by needs_fields config",
Expand Down Expand Up @@ -1054,15 +1063,6 @@
"null"
]
},
"root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"safety": {
"default": "",
"description": "Added by needs_fields config",
Expand Down
18 changes: 9 additions & 9 deletions src/tests/docs_bzl/scenarios/data_files_runfiles/_expected/isolated_source_bundle_needs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,15 @@
"null"
]
},
"failure_root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"fault_id": {
"default": "",
"description": "Added by needs_fields config",
Expand Down Expand Up @@ -1054,15 +1063,6 @@
"null"
]
},
"root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"safety": {
"default": "",
"description": "Added by needs_fields config",
Expand Down
18 changes: 9 additions & 9 deletions src/tests/docs_bzl/scenarios/data_files_runfiles/_expected/needs_json/needs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,15 @@
"null"
]
},
"failure_root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"fault_id": {
"default": "",
"description": "Added by needs_fields config",
Expand Down Expand Up @@ -1054,15 +1063,6 @@
"null"
]
},
"root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"safety": {
"default": "",
"description": "Added by needs_fields config",
Expand Down
18 changes: 9 additions & 9 deletions src/tests/docs_bzl/scenarios/nested_bundles/_expected/needs_json/needs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,15 @@
"null"
]
},
"failure_root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"fault_id": {
"default": "",
"description": "Added by needs_fields config",
Expand Down Expand Up @@ -1092,15 +1101,6 @@
"null"
]
},
"root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"safety": {
"default": "",
"description": "Added by needs_fields config",
Expand Down
18 changes: 9 additions & 9 deletions src/tests/docs_bzl/scenarios/reference_integration/_expected/root_needs_local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,15 @@
"null"
]
},
"failure_root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"fault_id": {
"default": "",
"description": "Added by needs_fields config",
Expand Down Expand Up @@ -1054,15 +1063,6 @@
"null"
]
},
"root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"safety": {
"default": "",
"description": "Added by needs_fields config",
Expand Down
18 changes: 9 additions & 9 deletions ...ts/docs_bzl/scenarios/reference_integration/legacy_module/_expected/needs_json/needs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,15 @@
"null"
]
},
"failure_root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"fault_id": {
"default": "",
"description": "Added by needs_fields config",
Expand Down Expand Up @@ -1094,15 +1103,6 @@
"null"
]
},
"root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"safety": {
"default": "",
"description": "Added by needs_fields config",
Expand Down
18 changes: 9 additions & 9 deletions .../reference_integration/legacy_module/docs/components/component/_expected/needs_local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,15 @@
"null"
]
},
"failure_root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"fault_id": {
"default": "",
"description": "Added by needs_fields config",
Expand Down Expand Up @@ -1094,15 +1103,6 @@
"null"
]
},
"root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"safety": {
"default": "",
"description": "Added by needs_fields config",
Expand Down
18 changes: 9 additions & 9 deletions ...ts/docs_bzl/scenarios/reference_integration/modern_module/_expected/needs_json/needs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,15 @@
"null"
]
},
"failure_root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"fault_id": {
"default": "",
"description": "Added by needs_fields config",
Expand Down Expand Up @@ -1183,15 +1192,6 @@
"null"
]
},
"root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"safety": {
"default": "",
"description": "Added by needs_fields config",
Expand Down
18 changes: 9 additions & 9 deletions ...e_integration/modern_module/docs/components/unlinked_component/_expected/needs_local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,15 @@
"null"
]
},
"failure_root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"fault_id": {
"default": "",
"description": "Added by needs_fields config",
Expand Down Expand Up @@ -1091,15 +1100,6 @@
"null"
]
},
"root_cause": {
"default": "",
"description": "Added by needs_fields config",
"field_type": "extra",
"type": [
"string",
"null"
]
},
"safety": {
"default": "",
"description": "Added by needs_fields config",
Expand Down
Loading
Loading