Skip to content

Use shm from communication, update deps, deprecations as warnings - #279

Merged
ChansAlive merged 2 commits into
eclipse-score:mainfrom
etas-contrib:feature/use_com_shm_and_update_deps
Oct 7, 2026
Merged

ChansAlive merged 2 commits into
eclipse-score:mainfrom
etas-contrib:feature/use_com_shm_and_update_deps

Conversation

@se-lo

@se-lo se-lo commented Oct 7, 2026

Copy link
Copy Markdown
Contributor
  • Use shm from score_communication
  • Add score_communication as dependency (for SHM) and update score_baselibs & score_logging
  • Enable deprecated declarations as error
    • Exempt: grpc_adapter and SoftHSM sources
  • Add missing copyright header

Closes #227
Closes #145

@se-lo
se-lo force-pushed the feature/use_com_shm_and_update_deps branch from b6b592e to 93f3972 Compare October 7, 2026 11:56
@se-lo
se-lo requested a deployment to workflow-approval October 7, 2026 11:56 — with GitHub Actions Waiting
@se-lo
se-lo requested a deployment to workflow-approval October 7, 2026 11:56 — with GitHub Actions Waiting
@se-lo
se-lo requested a deployment to workflow-approval October 7, 2026 11:56 — with GitHub Actions Waiting
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: ea03f4ec-22f7-475a-a6b2-b5e94d66f2e3
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'abseil-cpp+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-m3oGQwXp/ZTRJP+mzDWFkutCtdpYj7TgfQklSqQAhts="
DEBUG: Repository abseil-cpp+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
DEBUG: Rule 'protobuf+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-w6Cp7OiTLjHDtzbi2xixxC5wcM2biBOIsm0BqnHiTKI="
DEBUG: Repository protobuf+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
DEBUG: Rule 'grpc+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-CvN7gAlTEwtHwHW1ZoPuYL3D7aPDf8YAQZP1tWl1ggQ="
DEBUG: Repository grpc+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
WARNING: For repository 'score_bazel_platforms', the root module requires module version score_bazel_platforms@0.1.2, but got score_bazel_platforms@1.1.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_tooling', the root module requires module version score_tooling@2.2.1, but got score_tooling@2.2.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_process_description', the root module requires module version score_process_description@2.1.1, but got score_process_description@2.1.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
Analyzing: 0 targets (2 packages loaded)
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
INFO: Elapsed time: 16.849s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-279: https://eclipse-score.github.io/inc_security_crypto/pr-279/

@OliverHeilwagen OliverHeilwagen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with suggestions.

Comment thread .bazelrc
@se-lo
se-lo requested a deployment to workflow-approval October 7, 2026 12:55 — with GitHub Actions Waiting
@se-lo
se-lo requested a deployment to workflow-approval October 7, 2026 12:55 — with GitHub Actions Waiting
@se-lo
se-lo requested a deployment to workflow-approval October 7, 2026 12:55 — with GitHub Actions Waiting
Comment thread .bazelrc Outdated

build --per_file_copt=external/score_baselibs.*/.*@-Wno-deprecated-declarations
build --per_file_copt=external/score_logging.*/.*@-Wno-deprecated-declarations
common --@score_baselibs//score/json:base_library=nlohmann # TODO : https://github.com/eclipse-score/baselibs/issues/57

@OliverHeilwagen OliverHeilwagen Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please already switch to vajson, since nlohmann shall be deprecated in the future.
https://github.com/orgs/eclipse-score/discussions/2390?sort=new#discussioncomment-18779429

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, removed the manual selection of nlohmann

@se-lo
se-lo force-pushed the feature/use_com_shm_and_update_deps branch from 8c55ecb to 7c1d71a Compare October 7, 2026 13:55
@se-lo
se-lo deployed to workflow-approval October 7, 2026 13:56 — with GitHub Actions Active
@se-lo
se-lo deployed to workflow-approval October 7, 2026 13:56 — with GitHub Actions Active
@se-lo
se-lo deployed to workflow-approval October 7, 2026 13:56 — with GitHub Actions Active
@ChansAlive
ChansAlive merged commit 74d3406 into eclipse-score:main Oct 7, 2026
16 checks passed

This branch was successfully deployed

1 active deployment
workflow-approval — 7c1d71a6 Deployed Oct 7, 2026 by se-lo via Build and Test x86_64-qnx / approval #535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt Daemon to use shared memory coming from mw::com Fix all existing deprecation warnings

3 participants