Repository navigation
Use shm from communication, update deps, deprecations as warnings - #279
Merged
ChansAlive merged 2 commits intoOct 7, 2026
Merged
ChansAlive merged 2 commits into
ChansAlive merged 2 commits into
Conversation
se-lo
requested a deployment
to
workflow-approval
October 7, 2026 11:55 — with
GitHub Actions
Waiting
se-lo
requested a deployment
to
workflow-approval
October 7, 2026 11:55 — with
GitHub Actions
Waiting
se-lo
requested a deployment
to
workflow-approval
October 7, 2026 11:55 — with
GitHub Actions
Waiting
se-lo
force-pushed
the
feature/use_com_shm_and_update_deps
branch
from
October 7, 2026 11:56
b6b592e to
93f3972
Compare
se-lo
requested a deployment
to
workflow-approval
October 7, 2026 11:56 — with
GitHub Actions
Waiting
se-lo
requested a deployment
to
workflow-approval
October 7, 2026 11:56 — with
GitHub Actions
Waiting
se-lo
requested a deployment
to
workflow-approval
October 7, 2026 11:56 — with
GitHub Actions
Waiting
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Contributor
|
Documentation preview for this pull request is available at: |
OliverHeilwagen
approved these changes
Oct 7, 2026
OliverHeilwagen
left a comment
Contributor
There was a problem hiding this comment.
Approve with suggestions.
se-lo
requested a deployment
to
workflow-approval
October 7, 2026 12:55 — with
GitHub Actions
Waiting
se-lo
requested a deployment
to
workflow-approval
October 7, 2026 12:55 — with
GitHub Actions
Waiting
se-lo
requested a deployment
to
workflow-approval
October 7, 2026 12:55 — with
GitHub Actions
Waiting
|
|
||
| build --per_file_copt=external/score_baselibs.*/.*@-Wno-deprecated-declarations | ||
| build --per_file_copt=external/score_logging.*/.*@-Wno-deprecated-declarations | ||
| common --@score_baselibs//score/json:base_library=nlohmann # TODO : https://github.com/eclipse-score/baselibs/issues/57 |
Contributor
There was a problem hiding this comment.
please already switch to vajson, since nlohmann shall be deprecated in the future.
https://github.com/orgs/eclipse-score/discussions/2390?sort=new#discussioncomment-18779429
Contributor
Author
There was a problem hiding this comment.
As discussed, removed the manual selection of nlohmann
se-lo
force-pushed
the
feature/use_com_shm_and_update_deps
branch
from
October 7, 2026 13:55
8c55ecb to
7c1d71a
Compare
OliverHeilwagen
approved these changes
Oct 7, 2026
ChansAlive
approved these changes
Oct 7, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227
Closes #145