Repository navigation
ssh auth support - #144
Open
odra wants to merge 1 commit into
Open
ssh auth support#144odra wants to merge 1 commit into
odra wants to merge 1 commit into
Conversation
odra
force-pushed
the
ssh-auth
branch
2 times, most recently
from
October 21, 2026 17:48
376a253 to
a98651d
Compare
PiotrKorkus
reviewed
Oct 22, 2026
draganbjedov
requested changes
Oct 23, 2026
| @@ -0,0 +1,51 @@ | |||
| from types import SimpleNamespace | |||
Contributor
There was a problem hiding this comment.
Missing copyright header
| def test_resolve_ssh_auth_ok(qemu_target, username, password, pkey_path, expected): | ||
| ssh_opts = build_ssh_auth_args(password, pkey_path) | ||
|
|
||
| assert qemu_target._resolve_ssh_auth(username, **ssh_opts) == expected |
Contributor
There was a problem hiding this comment.
Add message to assert on all places
|
|
||
| def test_default_ssh_auth_is_empty_root_password(): | ||
| model = QemuConfigModel.model_validate(_VALID_BRIDGE_CONFIG) | ||
| assert model.ssh_auth.username == "root" |
Contributor
There was a problem hiding this comment.
Add message to assert on all places
Signed-off-by: odra <lrossett@redhat.com>
PiotrKorkus
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
ssh_authoption for qemu.