[shegazyy]

…nfig

All 8 timing fields in new_lm_flatcfg.fbs are changed from double (seconds) to uint32 (milliseconds), eliminating the need for the secondsToMs() conversion helper and removing the floating-point representation from the binary format entirely.

Changes:

• new_lm_flatcfg.fbs: 8 timing fields changed from double to uint32
• flatbuffer_config_loader.hpp: kExpectedSchemaVersion bumped 1 → 2
• flatbuffer_type_converters.hpp/.cpp: removed secondsToMs() and kSecondsToMilliseconds; all 7 call sites simplified to direct assignment
• flatbuffer_type_converters_UT.cpp: removed 5 SecondsToMsTest cases; updated all FlatBuffer builder calls to pass millisecond integers
• flatbuffer_config_loader_UT.cpp: updated all builder calls likewise
• lifecycle_config.py (gen_config): added sec_to_ms() conversion for all 8 timing fields so the generated JSON matches the new uint32 schema
• launch_manager.schema.json: updated schema_version enum from [1] to [2]
• All 20 JSON config files: "schema_version": 1 → "schema_version": 2

Closes #345

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: ab979ff3-9742-4fb5-a461-302038d14e60
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (44 packages loaded, 10 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (143 packages loaded, 2865 targets configured)

Analyzing: target //:license-check (160 packages loaded, 6259 targets configured)

Analyzing: target //:license-check (165 packages loaded, 6302 targets configured)

Analyzing: target //:license-check (165 packages loaded, 6308 targets configured)

Analyzing: target //:license-check (168 packages loaded, 9533 targets configured)

Analyzing: target //:license-check (172 packages loaded, 11429 targets configured)

INFO: Analyzed target //:license-check (173 packages loaded, 11555 targets configured).
[10 / 16] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 24.817s, Critical Path: 0.34s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

[github-actions]

The created documentation from the pull request is available at: docu-html

[NicolasFussberger]

The build with new config feature flag bazel build //score/... --config=x86_64-linux --//config:use_new_configuration=True is currently broken (not because of your changes, but because the compiler warnings are now enforced).

Could you apply this simple fix, to get your branch build successfully with new config flag active?

score/launch_manager/src/daemon/src/main.cpp:

         auto config_result = config_loader.load(config_path);
-        if (!config_result.has_value()) {
-            LM_LOG_FATAL() << "Failed to load config from: " << config_path;
+        if (!config_result.has_value())
+        {
+            LM_LOG_FATAL() << "Failed to load config from: " << std::string_view(config_path);
             return EXIT_FAILURE;
         }
 #endif

[NicolasFussberger]

Thanks for your contribution! Changes look good to me.

As explained in another comments, I'd only revert the schema version increase, as the json schema is not changed here.

Please take a look at the PR checks, there are some small things to fix to make them pass.

[shegazyy]

hey @NicolasFussberger PR checks fixed, ready for review whenever you have the time.

[github-actions]

Documentation preview for this pull request is available at:
pr-388: https://eclipse-score.github.io/lifecycle/pr-388/

[NicolasFussberger]

Thanks for updating the PR.
One minor point about the new polling_interval that was added recently, otherwise looks great to me

[shegazyy]

Hello @NicolasFussberger changes are applied please let me know if any other changes are requested

[MaciejKaszynski]

looks good

[NicolasFussberger]

thanks a lot @shegazyy. Would you also do the json schema changes as a follow up so that the user actually configured ms values instead of seconds?
This was previously only postponed due to the legacy config support which in the meantime has been removed.